[PATCH] don't pass NULL buffer to formatter in provider list generation

Pete Zaitcev zaitcev at redhat.com
Mon Jan 24 17:34:23 UTC 2011


On Mon, 24 Jan 2011 17:31:38 +0100
Jim Meyering <jim at meyering.net> wrote:

>  		qsort (plist.buf, plist.n_used, sizeof *(plist.buf),
>  		       prov_name_compare);
> 
> +		// Use a size that is large enough to accommodate the
> +		// result of formatting a few providers.
> +		// Not important, as long as it's larger than 0.
> +		ms->buf_n_alloc = 1024;
> +		ms->buf = malloc (ms->buf_n_alloc);
> +		if (ms->buf == NULL)
> +			return -1;

Looks good, ACK

-- Pete


More information about the iwhd-devel mailing list