dynamic providers and garbage collection

Jim Meyering jim at meyering.net
Mon Jan 17 20:34:56 UTC 2011


Jim Meyering wrote:

> Jeff Darcy wrote:
>> On 01/14/2011 04:49 PM, Jim Meyering wrote:
>>> I have 3 tasks on my short-term TODO list:
>>>  - mutex-protect the two provider iteration loops in replica.c
>>>  - plug a small leak in meta.cpp
>>>  - fix meta.cpp so it doesn't come up with a reference to malloc
>>>      (as opposed to GC_malloc).  I think it does this via some mongodb
>>>      method that uses a json-related inline extern-C function.
>>
>> This is related to a concern I had when looking at the diffs.  I see
>> that free_ms has been eliminated in favor of GC voodoo, but the call to
>> meta_query_stop might actually have been necessary.  It's probably also
>
> Good catch.
> I'll look into that.
> It looks like the same applies to meta_attr_stop,
> both of which (I now see) are unused functions.
> I'd better start using tools/options (coverity, maybe clang, gcc lto)
> that would catch that.

Those two functions free memory that is allocated from
within meta.cpp, so once meta.cpp is GC-enabled, those
will be automatically freed by the magic of GC.


More information about the iwhd-devel mailing list