[PATCH] diagnose object write failure with FS back-end

Pete Zaitcev zaitcev at redhat.com
Mon Dec 5 21:13:06 UTC 2011


On Mon, 05 Dec 2011 21:12:51 +0100
Jim Meyering <jim at meyering.net> wrote:

>  	fd = open(fixed,O_WRONLY|O_CREAT|O_EXCL,0666);
>  	if (fd < 0) {
> -		pipe_cons_siginit(ps, errno);
> +		error (0, errno, _("failed to open file: %s"), fixed);
> +		pipe_cons_siginit(ps, -1);
>  		free(pp);

I ACK this.

There was supposed to be a migration to log_msg, but it can be
wholesale.

Also, I wish you added the filename into the printout. It may seem
pointless, since it's not visible to the user and is internal to iwhd,
but actually it helps for the administrator in case of disk errors
and the like.

-- Pete


More information about the iwhd-devel mailing list