[PATCH] tests: don't clutter regular output with expected diagnostics

Jim Meyering jim at meyering.net
Tue Oct 19 17:26:37 UTC 2010


FYI, trivial again.

Before, "make check" would output a lot of generally useless info:

    PASS: parser-test
    cmd took 1 x .1s: 'mongo localhost:$m_port < /dev/null'
    cmd took 1 x .1s: 'mongo localhost:$m_port < /dev/null'
    cmd took 1 x .1s: 'mongo localhost:$m_port < /dev/null'
    cmd took 1 x .1s: 'curl -s http://localhost:9091'
    cmd took 1 x .1s: 'curl http://localhost:9092'
    cmd took 1 x .1s: 'curl http://localhost:9093'
    PASS: basic
    cmd took 8 x .1s: 'curl -s http://localhost:9094'
    PASS: auto
    EXPIRED: 50 x .1s: 'wait_for_repl http://localhost:9092'
    replication: failed test: replication seems stuck
    FAIL: replication

Now, it prints only the exceptional part of that:
(the rest is still printed, but only to the log)

    PASS: parser-test
    PASS: basic
    PASS: auto
    EXPIRED: 50 x .1s: 'wait_for_repl http://localhost:9092'
    replication: failed test: replication seems stuck
    FAIL: replication


>From 9ca9c3d6bdd3d210b5c58fca4bc9c63aacbea78d Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering at redhat.com>
Date: Tue, 19 Oct 2010 19:24:08 +0200
Subject: [PATCH] tests: don't clutter regular output with expected diagnostics

* t/init.cfg (wait_for): Emit common diagnostic to log, not tty.
---
 t/init.cfg |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/t/init.cfg b/t/init.cfg
index 90bb390..0b92496 100644
--- a/t/init.cfg
+++ b/t/init.cfg
@@ -31,7 +31,7 @@ wait_for()
   esac
   local i=0
   while :; do
-    eval "$cmd" && { warn_ "cmd took $i x ${sleep_seconds}s: '$cmd'"; return 0; }
+    eval "$cmd" && { echo "cmd took $i x ${sleep_seconds}s: '$cmd'"; return 0; }
     sleep $sleep_seconds
     i=$(expr $i + 1)
     test $i = $max_n_sleeps \
--
1.7.3.1.526.g2ee4


More information about the iwhd-devel mailing list