[PATCH] don't ignore write failures

Jeff Darcy jdarcy at redhat.com
Tue Oct 5 19:38:52 UTC 2010


On 10/05/2010 03:28 PM, Pete Zaitcev wrote:
> On Tue, 05 Oct 2010 13:10:49 -0400
> Jeff Darcy <jdarcy at redhat.com> wrote:
> 
>> On 10/04/2010 06:16 PM, Pete Zaitcev wrote:
> 
>>> I need to check this though. I don't even remember a function called
>>> "junk_writer", maybe I missed a piece of code that needed chaning.
>>
>> OK, when you have checked, could you please ACK/NAK Jim's patch
>> appropriately?  Thanks.
> 
> I wanted to vote present on this, because I don't like pointless checking
> of fflush for messages (even if stdout is redirected to a file and gets
> EFULL -- chances are stderr ends there as well).
> 
> The main check in junk_writer is definitely ok, especially in the
> 2nd try with ||, because my changes only involved a case when producer
> and consumer used our "multiplex" pipe (mpipe), but the replication
> uses a system pipe.

I'm going to consider that an ACK.  Full steam ahead, Jim.


More information about the iwhd-devel mailing list