[Fwd: add leading _ to each reserved attribute name; _size is reserved, too]

Jeff Darcy jdarcy at redhat.com
Mon Nov 8 13:31:27 UTC 2010


On 11/06/2010 03:08 AM, Jim Meyering wrote:
> With this incremental reverting three of the changes,
> I think it does what we want:

Looks good.  ACK again.

> diff --git a/rest.c b/rest.c
> index fada136..96b8348 100644
> --- a/rest.c
> +++ b/rest.c
> @@ -998,7 +998,7 @@ root_blob_generator (void *ctx, uint64_t pos, char *buf, int max)
>  	}
> 
>  	if (meta_query_next(ms->query,&bucket,&key)) {
> -		len = tmpl_root_entry(ms->gen_ctx,"_bucket",bucket);
> +		len = tmpl_root_entry(ms->gen_ctx,"bucket",bucket);
>  		if (!len) {
>  			return -1;
>  		}
> diff --git a/t/basic b/t/basic
> index 71821f8..3d610d9 100644
> --- a/t/basic
> +++ b/t/basic
> @@ -31,7 +31,7 @@ cat <<EOF > root.xml || framework_failure_
>  <api service="image_warehouse" version="$VERSION">
>  	<link rel="bucket_factory" href="http://localhost:$port/_new"/>
>  	<link rel="provider_list" href="http://localhost:$port/_providers"/>
> -	<link rel="_bucket" href="$bucket"/>
> +	<link rel="bucket" href="$bucket"/>
>  </api>
>  EOF
> 
> @@ -49,7 +49,7 @@ cat <<EOF > root.json || framework_failure_
>  			"link": "http://localhost:$port/_providers"
>  		},
>  		{
> -			"rel": "_bucket",
> +			"rel": "bucket",
>  			"link": "$bucket"
>  		}
>  	]


More information about the iwhd-devel mailing list