Patches pending review

Simo Sorce ssorce at redhat.com
Tue May 5 18:39:56 UTC 2015


----- Original Message -----
> From: "Rob Crittenden" <rcritten at redhat.com>
> To: "Ipsilon" <ipsilon at lists.fedorahosted.org>
> Sent: Tuesday, May 5, 2015 2:13:48 PM
> Subject: Patches pending review
> 
> Here is a list of the patches I have pending review:
> 
> ticket 35:
> https://fedorapeople.org/cgit/rcritten/public_git/ipsilon.git/.git/commit/?h=logger&id=41ea3772220b37690c7fae6a79f1b13efc7a4f8b

This one looks good but seem to need a rebase, cherry-pick barfs.

> ticket 90:
> https://fedorapeople.org/cgit/rcritten/public_git/ipsilon.git/.git/log/?h=db_sessions

I've had no time to look at this one yet.

> ticket 111:
> https://fedorapeople.org/cgit/rcritten/public_git/ipsilon.git/.git/commit/?h=no_sssd_ui&id=f6d2225ec4325275f1eeb0b8089f1d598a7e7fc4

This is reaaaallly ugly, can we rather have a config option we look for and not enable sssd
if this optoin is not set ?
This way you *can* enable/disable it via the admin UI, which is handy if you are testing
stuff as an admin, you just shouldn't be able to change the configuration. (mark the module
cnfiguration with a "read-only" property somewhere ?

> ticket 116:
> https://fedorapeople.org/cgit/rcritten/public_git/ipsilon.git/.git/commit/?h=gssapi_test

I think we shouldn't really allow non-mutual auth, if that check is because mod_auth_gssapi
fails to reutn the token on a 200 OK, then we just need to require a new enough
mod_auth_gssapi, Ifixed that bug in master a couple of weeks ago, and can make a release
if necessary.
Otherwise it looks good, but haven't yet tested it.

> ticket 120:
> https://fedorapeople.org/cgit/rcritten/public_git/ipsilon.git/.git/commit/?h=remove_dash_debug&id=7c4e702c0b2504f7b0540886f69ec930cc455f90

ACK and pushed this one to master.

HTH,
Simo.

-- 
Simo Sorce * Red Hat, Inc. * New York


More information about the ipsilon mailing list