[PATCH v2 3/4] Fix make distcheck

Jiri Popelka jpopelka at redhat.com
Thu Nov 22 15:31:22 UTC 2012


On 11/19/2012 02:09 PM, Thomas Woerner wrote:
> On 11/15/2012 04:01 PM, Jiri Popelka wrote:
>> On 11/08/2012 04:28 PM, Doug Goldstein wrote:
>>> Problem is without the $(prefix) it will fail a make distcheck. That's
>>> fine however as I was likely going to adopt the way the systemd unit
>>> path is provided in other projects in a follow on patch.
>>
>> I've just noticed this NM commit
>> http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=2750b0759f1250ccfb37389fb88b13bb1151ff0e 
>>
>>
>> which also handles the systemd service file installation
>> and I see the $(prefix) usage there, so maybe something
>> similar could solve the problem.
>>
> I like this solution much more than the other one. Setting this in 
> configure is much more expected than in a Makefile in my opinion.
>
> We should also rename configure.in to configure.ac. The use of 
> configure.in will not be supported that long anymore.

Both done.
'make distcheck' now succeeds.
I've crated a build-cleanups branch which contains Doug's and my changes.

Thomas, if you are happy with it just merge it to master.

--
Jiri


More information about the firewalld-devel mailing list