[PATCH] firewall-cmd: fix usage()

Jiri Popelka jpopelka at redhat.com
Tue Feb 28 16:42:51 UTC 2012


I've been confused with the following:
--add|--enable - this looks like they are synonyms which isn't true
--remove|--disable - the same as previous
--masquerade action can be used only with --enable|--disable|--query
---
 src/firewall-cmd |   15 +++++++++------
 1 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/src/firewall-cmd b/src/firewall-cmd
index 174ff55..5759508 100755
--- a/src/firewall-cmd
+++ b/src/firewall-cmd
@@ -45,18 +45,21 @@ def usage():
     --get-zone-of-interface=<interface>
 
     --zone=<zone>
-  Modes:
-    --add|--enable [--timeout=<seconds>] <action>
-    --remove|--disable <action>
-    --query <action>
+  Mode:
+    --add [--timeout=<seconds>] <action>
+    --remove <action>
+    --enable [--timeout=<seconds>] <masquerade>
+    --disable <masquerade>
+    --query <action> | <masquerade> 
     --list=<action>
-  Actions:
+  Action:
     --service=<service>
     --port=<port>[-<port>]/<protocol>
     --interface=<interface>
-    --masquerade
     --forward-port=port=<port>:proto=<protocol>[:toport=<destinaton port>][:toaddr=<destination address>]
     --icmp-block=<icmp type>
+  Masquerade:
+    --masquerade
 """)
 
 try:
-- 
1.7.7.6



More information about the firewalld-devel mailing list