[PATCH] firewall-cmd: fix bug in --list=port and --port action help message

Jiri Popelka jpopelka at redhat.com
Tue Feb 28 15:13:49 UTC 2012


---
 src/firewall-cmd |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/firewall-cmd b/src/firewall-cmd
index e60d6c3..1063060 100755
--- a/src/firewall-cmd
+++ b/src/firewall-cmd
@@ -53,7 +53,7 @@ def usage():
     --list=interface                     lists interfaces of a zone
   Actions:
     --service=<service>
-    --port=<port>[-<port>]:<protocol>
+    --port=<port>[-<port>]/<protocol>
     --masquerade
     --forward-port=port=<port>:proto=<protocol>[:toport=<destinaton port>][:toaddr=<destination address>]
     --icmp-block=<icmp type>
@@ -262,7 +262,7 @@ try:
             if mode == "list":
                 l = fw.getPorts(zone)
                 if len(l) > 0:
-                    print(", ".join(["%s/%s" % port for port in l]))
+                    print(", ".join(["%s/%s" % (port[0], port[1]) for port in l]))
             else:
                 try:
                     (port, proto) = value.split("/")
-- 
1.7.7.6



More information about the firewalld-devel mailing list