[PATCH] Adjust license checker to take into account new-style %license files

Michel Alexandre Salim michel at michel-slm.name
Tue Feb 3 09:36:31 UTC 2015


Dear Fedora Review developers,

When conducting a review I noticed that specs that use the new %license tag
to mark the license file get flagged as not having a license text by
fedora-review -- this is, as it turns out, because RPM's -d flag does not
display files tagged as licenses; one needs the exclusive -L flag to
display that.

This patch runs rpm twice, once with -d and once with -L, and collect the
candidate files from both runs. It also drops the redundant -l which both
-d and -L imply.

As tested with:
https://bugzilla.redhat.com/show_bug.cgi?id=1173159

Reference:
FPC proposal for using %license instead of %doc
https://fedorahosted.org/fpc/ticket/411

RPM %license tag handling
http://www.rpm.org/ticket/116

Best regards,

-- 
Michel Alexandre Salim
Fedora Project Contributor (FAS: salimma, IRC: michel_slm)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/fedorareview/attachments/20150203/9dbb33f1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Adjust-license-checker-to-take-into-account-new-styl.patch
Type: text/x-patch
Size: 1174 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/fedorareview/attachments/20150203/9dbb33f1/attachment.bin>


More information about the fedorareview mailing list