[PATCH 6/6] Provide assert_perror when it's not defined

Max Filippov jcmvbkbc at gmail.com
Mon May 4 14:48:39 UTC 2015


On Mon, May 4, 2015 at 5:22 PM, Mark Wielaard <mjw at redhat.com> wrote:
> On Mon, May 04, 2015 at 07:53:27AM +0200, Petr Machata wrote:
>> Max Filippov <jcmvbkbc at gmail.com> writes:
>>
>> > assert_perror is a GNU extension and is not provided by uClibc. Provide
>> > definition when that macro is not available.
>>
>> It looks like it would pay off to have a dedicated header file for this
>> macro.
>
> Yes, but it is only needed in the backtrace tests. So please make it a
> tests only header. But since this is in the tests a simple assert (errno)
> would IMHO also be fine. It is just there to make sure the tests fail on
> something unexpected. For real code we should do proper error checking.

Ok, I'll turn assert_perrors to simple asserts.

-- 
Thanks.
-- Max


More information about the elfutils-devel mailing list