[PATCH] elflint: Only check the PT_TLS phdr if it actually exists.

Mark Wielaard mjw at redhat.com
Fri Jun 19 11:05:45 UTC 2015


On Thu, 2015-06-18 at 11:28 -0700, Roland McGrath wrote:
> It should complain separately for that case, not just be silent.

You are right. I made it into its own case and complain.

> Arguably, it should just barf if any gelf_getphdr call fails, because
> that can only be due to a deep bogon.

Yeah, maybe elflint should really just wrap gelf_getphdr and
gelf_getshdr and complain and quit when they return NULL instead of
trying to continue. The ELF file is probably completely bogus anyway in
those cases.

Thanks,

Mark


More information about the elfutils-devel mailing list