[PATCH] elf_begin sets elf_errno for cases that the file is completely unreadable

Roland McGrath roland at hack.frob.com
Wed Sep 10 20:36:56 UTC 2014


>    if (unlikely (nread == -1))
> -    /* We cannot even read the head of the file.  Maybe FILDES is associated
> -       with an unseekable device.  This is nothing we can handle.  */
> -    return NULL;
> +    {
> +      __libelf_seterrno (ELF_E_INVALID_FILE);
> +      /* We cannot even read the head of the file.  Maybe FILDES is associated
> +	 with an unseekable device.  This is nothing we can handle.  */
> +      return NULL;
> +    }

That looks sensible, though I'd keep the comment at the top of the block.


More information about the elfutils-devel mailing list