dwarf_aggregate_size() seems to fall over on pointer types

Mark Wielaard mjw at redhat.com
Thu Oct 2 12:05:36 UTC 2014


On Wed, 2014-10-01 at 15:26 -0400, Conrad Rad wrote:
> On Wed, Oct 1, 2014 at 3:23 PM, Conrad Rad <cse.cem at gmail.com> wrote:
> > This should be 0, 0x8. The size goes in the *size, return value of
> > dwarf_aggregate_size() should be zero on success, not 8. The patch is
> > not good as is.
> >
> With the fixed patch (attached), it works:

Oops. That shows why I shouldn't submit patches without testcases...
Thanks for testing and fixing.

Here is the fixed up patch plus some testcases to show it actually
works.

Cheers,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libdw-dwarf_aggregate_size-return-CU-address_size-fo.patch
Type: text/x-patch
Size: 11987 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/elfutils-devel/attachments/20141002/3e264fa5/attachment-0001.bin>


More information about the elfutils-devel mailing list