[COMMITTED] readelf: Cast Dwarf_Word length to ptrdiff_t for comparison.

Mark Wielaard mjw at redhat.com
Wed Nov 26 23:34:29 UTC 2014


My last patch caused a compiler warning/error on some setups. My apologies.

Avoid comparison between signed and unsigned integer expressions warning.

Signed-off-by: Mark Wielaard <mjw at redhat.com>
---
 src/ChangeLog | 5 +++++
 src/readelf.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/ChangeLog b/src/ChangeLog
index 0082e65..a6d18b5 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,8 @@
+2014-11-26  Mark Wielaard  <mjw at redhat.com>
+
+	* readelf.c (print_debug_aranges_section): Cast Dwarf_Word length
+	to ptrdiff_t for comparison.
+
 2014-11-24  Mark Wielaard  <mjw at redhat.com>
 
 	* readelf.c (print_debug_line_section): Check line_range is not zero
diff --git a/src/readelf.c b/src/readelf.c
index 00986d1..cd15e4c 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -4693,7 +4693,7 @@ print_debug_aranges_section (Dwfl_Module *dwflmod __attribute__ ((unused)),
       printf (gettext ("\n Length:        %6" PRIu64 "\n"),
 	      (uint64_t) length);
 
-      if (unlikely (length > readendp - readp))
+      if (unlikely ((ptrdiff_t) length > readendp - readp))
 	goto invalid_data;
 
       if (length == 0)
-- 
1.8.3.1



More information about the elfutils-devel mailing list