[patch 2/3] Fix abort() on missing section headers

Mark Wielaard mjw at redhat.com
Mon Mar 3 16:05:39 UTC 2014


On Sun, 2014-03-02 at 22:35 +0100, Jan Kratochvil wrote:
> On Tue, 25 Feb 2014 23:30:55 +0100, Mark Wielaard wrote:
> > We certainly shouldn't abort on bad data!
> > But do we even need to continue at this point?
> > 
> > return result; means we will keep searching through the section table,
> > which apparently is busted anyway. So I think it makes sense to cleanup
> > and return NULL; instead.
> > 
> > See how we cleanup and return NULL just below this code when elf_strptr
> > fails.
> 
> Yes, I agree.
>
> 2014-03-02  Jan Kratochvil  <jan.kratochvil at redhat.com>
> 
> 	Fix abort() on missing section headers.
> 	* dwarf_begin_elf.c (check_section): Replace abort call by goto err.
> 	New label err to return NULL.

Looks good.

Thanks,

Mark



More information about the elfutils-devel mailing list