[PATCH] libdw: Add overflow checking to __libdw_form_val_len.

Mark Wielaard mjw at redhat.com
Thu Dec 11 14:11:21 UTC 2014


On Tue, 2014-12-09 at 18:44 -0800, Josh Stone wrote:
> Ok, well my former optimizations went into 0.158.  Here are some quick
> runs of "varlocs -k >/dev/null" on kernel-3.17.4-301.fc21.x86_64:
> 
> 0.157	96.00user 0.12system 1:36.08elapsed
> 0.158	70.22user 0.12system 1:10.32elapsed
> 0.159	71.40user 0.11system 1:11.48elapsed
> 0.160	73.24user 0.12system 1:13.33elapsed
> master	77.65user 0.10system 1:17.72elapsed
> patched	77.87user 0.10system 1:17.93elapsed
> 
> So each release has ceded a bit of performance, but this particular
> patch isn't much of an issue.  Correctness trumps performance anyway.

Thanks for all the testing (and for your patches trying to get our
performance back). I have now pushed this overflow checking patch to
master.

Cheers,

Mark


More information about the elfutils-devel mailing list