[PATCH 2/3] libdw: optimize dwarf_hasattr to just look at abbrev

Mark Wielaard mjw at redhat.com
Thu Dec 11 11:34:45 UTC 2014


On Wed, 2014-12-10 at 18:48 -0800, Josh Stone wrote:
> To just check the presence of an attribute, we only need to look at the
> abbreviation data.  This optimization avoids reading over die data at all,
> except possibly just to get the abbrev code.
>
>  2014-12-10  Josh Stone  <jistone at redhat.com>
> +	* dwarf_hasattr.c (dwarf_hasattr): Just walk abbrev for presence.
> +

Sorry for the irritating nitpick, but there is a missing blank line
after the date line in the ChangeLog entry.

Looks nice. Good find!

Thanks,

Mark


More information about the elfutils-devel mailing list