[PATCH 2/3] Simplify and inline get_uleb128 and get_sleb128

Petr Machata pmachata at redhat.com
Wed Apr 23 22:32:48 UTC 2014


Mark Wielaard <mjw at redhat.com> writes:

> On Wed, 2014-04-23 at 22:29 +0200, Petr Machata wrote:
>> How's this for a counter-proposal?  I shamelessly reused your commit
>> message and ChangeLog wording, please let me know if that's overstepping
>> boundaries.
>
> No it isn't. And thanks for the proposal.
> But I think I prefer the fix using multiplication as posted here:
> https://lists.fedorahosted.org/pipermail/elfutils-devel/2014-April/003991.html
> That one is also just a oneliner and more generic since it doesn't rely
> on having to cast to uint64_t. And Richard checked it still just
> generates a shift.

Ah, cool, I didn't notice that e-mail.

Thanks,
PM


More information about the elfutils-devel mailing list