[PATCH] libdw: Make dwarf_getfuncs find all (defining) DW_TAG_subprogram DIEs.

Mark Wielaard mjw at redhat.com
Tue Sep 24 08:53:21 UTC 2013


On Mon, 2013-09-23 at 14:49 -0700, Josh Stone wrote:
> On 09/22/2013 02:12 PM, Mark Wielaard wrote:
> > On irc Tom Tromey suggested to trust the CU language to win back most
> > speed for programs mainly written in C (like the kernel). The attached
> > patch does that. With this variant of the patch you get all correctness
> > benefits (imported/partial unit support and detection of nested functions
> > in C code, plus detection of defining subprograms inside other constructs
> > for other langauges), but with a slowdown of < 0.1s in this particular case.
> 
> Confirmed, I'm down to just about .1s added to the kernel queries.
> 
> Looks good to me!

Thanks for all your reviews, testing and even implementing an
alternative implementation. I have pushed this variant to master now.

Hopefully with your suggestions for some improvements in the DIE
classifying we can get rid of the last remaining "slowdown".

Cheers,

Mark



More information about the elfutils-devel mailing list