[PATCH] libdw: Make dwarf_getfuncs find all (defining) DW_TAG_subprogram DIEs.

Mark Wielaard mjw at redhat.com
Fri Sep 20 13:55:07 UTC 2013


Hi Josh,

On Thu, 2013-09-19 at 18:42 -0700, Josh Stone wrote:
> With systemtap-debuginfo-2.3-1.fc19.x86_64, my patched stap.git found
> 75713 probes in 'process("/usr/bin/stap").function("*")' (as counted by
> the pass-2 -v line).  Unpatched stap.git with your patched elfutils.git
> found only 61056 probes.  :(

The attached patch fixes the partial/imported unit issue you found.
Which actually made the implementation simpler. I also added some
comments to the libdw.h dwarf_getfuncs documentation.

But it still doesn't seem to find as many probes as you do:
Pass 2: analyzed script: 72231 probe(s) [...]

Of course this does much more than just finding the defining
subprograms. So we might not be comparing the exact same thing. Could
you post you systemtap patch somewhere? I am just using the packaged
systemtap-2.3-1.fc19.x86_64 on itself with LD_LIBRARY_PATH pointing to a
elfutils git build with the below patch.

Thanks,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libdw-Make-dwarf_getfuncs-find-all-defining-DW_TAG_s.patch
Type: text/x-patch
Size: 18288 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/elfutils-devel/attachments/20130920/8136a5b0/attachment.bin>


More information about the elfutils-devel mailing list