[patch 3/4] unwinder: Provide dwfl_core_filename_report

Mark Wielaard mjw at redhat.com
Thu May 30 09:54:03 UTC 2013


On Wed, 2013-05-29 at 18:12 +0200, Jan Kratochvil wrote:
> On Wed, 29 May 2013 11:07:02 +0200, Mark Wielaard wrote:
> > So the issue is that __libdw_open_file does a bit more than elf_begin?
> > In particular it handles compressed images.
> > 
> > I do agree that it would be nice to be able to handle that transparently
> > without needing access to an internal function, so a quick review below.
> > But I do wonder if you cannot just directly open the Elf *core with
> > elf_begin in your use case?
> 
> I did not know elf_begin.
> 
> It seems as a duplication to elf_begin now to me.  If you are fine with that
> I will rather use elf_begin instead in [patch 4/4].

Yes, elf_begin is slightly less capable than having some helper function
that uses __libdw_open_file, but I think it is fine in that case.

Thanks,

Mark



More information about the elfutils-devel mailing list