[PATCH] readelf: Accept version 8 .gdb_index section format. Fix memory leak.

Mark Wielaard mjw at redhat.com
Tue Mar 19 10:49:47 UTC 2013


On Mon, 2013-03-18 at 14:05 +0100, Jan Kratochvil wrote:
> > @@ -7272,8 +7272,9 @@ print_gdb_index_section (Dwfl_Module *dwflmod, Ebl *ebl, GElf_Ehdr *ehdr,
> >  
> >    // The only difference between version 4 and version 5 is the
> >    // hash used for generating the table.  Version 6 contains symbols
> > -  // for inlined functions, older versions didn't.
> > -  if (vers < 4 || vers > 7)
> > +  // for inlined functions, older versions didn't.  Version 7 adds
> > +  // symbol kinds.
> > +  if (vers < 4 || vers > 8)
> 
> Here could be copy-pasted the difference of version 8 from your mail above.

Added.

> > +      free (l);
> > +      free (h);
> >        n++;
> 
> This is really very unrelated (->separate) patch.

Grin. It is just a 3 line patch. But yeah, OK.
Separated and pushed in two commits.

Thanks,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-readelf-Accept-version-8-.gdb_index-section-format.patch
Type: text/x-patch
Size: 1862 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/elfutils-devel/attachments/20130319/a884c3f8/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-readelf-print_gdb_index_section-fix-memory-leak.patch
Type: text/x-patch
Size: 1131 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/elfutils-devel/attachments/20130319/a884c3f8/attachment-0001.bin>


More information about the elfutils-devel mailing list