[PATCH 1/3] Add an inlined fast path for __libdw_form_val_len

Josh Stone jistone at redhat.com
Mon Dec 16 22:30:29 UTC 2013


On 12/16/2013 02:18 PM, Roland McGrath wrote:
>> +  /* Note that form_lengths[flag_present] is 0, like every other absent index.
>> +   * But since flag_present's length truly is 0, check for it explicitly.  */
> 
> Extra * is bad comment formatting.

Right, Petr caught that on v2.  These are committed now, but of course
I'll still go back and address concerns if needed...

Thanks,
Josh



More information about the elfutils-devel mailing list