[PATCH v2 1/3] libdw: Add an inlined fast path for __libdw_form_val_len

Petr Machata pmachata at redhat.com
Fri Dec 13 14:19:47 UTC 2013


Josh Stone <jistone at redhat.com> writes:

> +  /* Small lookup table of forms with fixed lengths.  Absent indexes are
> +   * initialized 0, so any truly desired 0 is set to 0x80 and masked.  */

/* GNU coding style has comments that go
   without continuation asterisks.  */

Sorry, I didn't notice this before.  Or maybe it wasn't there, I don't
know.  The patch is fine otherwise, so it can be committed without
re-posting after this is corrected.

> +  /* NB: This doesn't cover constant form lengths, which are
> +   * already handled by the inlined __libdw_form_val_len.  */

Here as well.

Thanks,
PM


More information about the elfutils-devel mailing list