[PATCH 1/2] Enable automake parallel-tests for make check.
mjw at redhat.com
Fri Apr 26 11:21:45 UTC 2013
On Thu, 2013-04-25 at 14:19 -0700, Roland McGrath wrote:
> Looks generally OK. A few potential clean-ups:
> I think it will keep everyone saner in the long run if canonical variables
> like srcdir have their canonical meanings everywhere. So if you really
> need them to use an absolute directory name, then make them use abs_srcdir
> as the variable name for that.
Yes, that is cleaner. I export abs_srcdir from the Makefile now and use
that instead of (relative) paths from srcdir.
> Rather than various numbers of ../ prefixes, perhaps it would become easier
> to read and to maintain if all those were rewritten in terms of builddir
> and/or top_builddir (i.e. $top_builddir/src/readelf, etc.).
Yes, the multiple ../ prefixes might not be as easy to read/understand
immediately. Since we are using abs_srcdir above already I paired it
with abs_builddir and reference all input files in the run-test*sh
scripts. So everything in the tests should now be referenced either from
the current test directory, using abs_srcdir or abs_builddir.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 59544 bytes
Desc: not available
More information about the elfutils-devel