[PATCH] show_symbols_sysv: Fix incorrect size in snprintf

Mark Wielaard mjw at redhat.com
Tue Dec 11 21:29:40 UTC 2012

On Tue, Dec 11, 2012 at 09:42:29AM -0800, Roland McGrath wrote:
> I fixed it in a way that doesn't repeat the string.

But you forget a semicolon...
Fixed it the following commit.

commit 7df3d2cd70932cd70515dbeb75e4db66fd27f192
Author: Mark Wielaard <mjw at redhat.com>
Date:   Tue Dec 11 22:27:05 2012 +0100

    Add missing semicolon in show_symbols_sysv
    Signed-off-by: Mark Wielaard <mjw at redhat.com>

diff --git a/src/nm.c b/src/nm.c
index 8a1c57a..7aae84b 100644
--- a/src/nm.c
+++ b/src/nm.c
@@ -769,7 +769,7 @@ show_symbols_sysv (Ebl *ebl, GElf_Word strndx, const char *fullname,
                               gelf_getshdr (scn, &shdr_mem)->sh_name);
       if (unlikely (name == NULL))
-          const size_t bufsz = sizeof "[invalid sh_name 0x12345678]"
+         const size_t bufsz = sizeof "[invalid sh_name 0x12345678]";
          name = alloca (bufsz);
          snprintf (name, bufsz, "[invalid sh_name %#" PRIx32 "]",
                    gelf_getshdr (scn, &shdr_mem)->sh_name);

More information about the elfutils-devel mailing list