[PATCH 1/4] Rewrite DWARF string functions using known-dwarf macros.

Mark Wielaard mjw at redhat.com
Sat Aug 4 12:30:11 UTC 2012


> I don't like losing the "lo_user+%#x" cases.

Yeah, the original code was sometimes inconsistent in this regard.
I have rewritten the patch to consistently use "lo_user+%#x" in case
an unknown vendor extension is encountered.

> I also don't like "unknown_%#x".  It should just be "%#x".

Again the original code inconsistent, sometimes just using "???"
to indicate something was wrong. I want there to be a clear indicator
that something is wrong/missing (just like in the case of an unknown
vendor extension). Which is why it is not just a bare "%#x" string.

Patch series rewritten and rebased, also on mjw/dwarfstrings branch.

Thanks,

Mark


More information about the elfutils-devel mailing list