Merged "sane" commits from mjw/dwarf_output to dwarf branch

Petr Machata pmachata at redhat.com
Thu Mar 17 18:55:41 UTC 2011


Mark Wielaard <mjw at redhat.com> writes:

> On Wed, 2011-03-16 at 14:40 -0700, Roland McGrath wrote:
>> Well, that's what dwarflint is for.  There is nothing algorithmically
>> difficult about handling direct self-reference in the hash function.
>> It exists in some data, whether by producer bug or not, so we have to
>> handle it.  The kludge is just too ugly.
>
> I added a dwarflint pass for it.
> Attached and on the mjw/check_self_referential_die
>
> Output of warning (on dwarfcmp, the problematic binary):
> warning: .debug_info: DIE 0xed86a: attribute containing_type references DIE itself.
> warning: .debug_info: DIE 0x1710eb: attribute containing_type references DIE itself.
>
> Petr, if you think that is correct, I like to merge it to the dwarf
> branch.

It looks correct to me.  I merged and added a test case.

Thanks,
PM


More information about the elfutils-devel mailing list