[PATCH] doubled words
Mark Wielaard
mjw at redhat.com
Sat Apr 16 11:56:21 UTC 2011
> On Sat, Apr 16, 2011 at 06:12, Mark Wielaard <mjw at redhat.com> wrote:
> > I read through the patch and the changes all seem fine to me.
>
> But it's not. The last change for ldgeneric.c should fix up the whole
> comment and not change just the duplication. If these types of
> changes are made then they better be complete.
Could you be a bit more specific? I reread the comment and the following
code, and the comment seems to describe what it does. I might be missing
something, but I don't immediately see what.
> Aside, changes without any code changes shouldn't pollute the
> ChangeLog files.
Yeah, it would be bad if there were constant comment "cleanups".
But I assume this is a one time thing.
Thanks,
Mark
More information about the elfutils-devel
mailing list