[ABRT PATCH] add a switch to debuginfo installer to leave rpms in tmpdir - closes #700

Petr Kubat pkubat at redhat.com
Thu Sep 12 09:20:44 UTC 2013


Signed-off-by: Petr Kubat <pkubat at redhat.com>
---
 src/plugins/abrt-action-install-debuginfo.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/plugins/abrt-action-install-debuginfo.in b/src/plugins/abrt-action-install-debuginfo.in
index 3a6ca7f..1089860 100644
--- a/src/plugins/abrt-action-install-debuginfo.in
+++ b/src/plugins/abrt-action-install-debuginfo.in
@@ -86,7 +86,7 @@ if __name__ == "__main__":
     help_text = _(
             "Usage: %s [-vy] [--ids=BUILD_IDS_FILE]\n"
             "       [--tmpdir=TMPDIR] [--cache=CACHEDIR[:DEBUGINFODIR1:DEBUGINFODIR2...]] [--size_mb=SIZE]\n"
-            "       [-e, --exact=PATH]\n"
+            "       [-e, --exact=PATH] [--keeprpms]\n"
             "\n"
             "Installs debuginfos for all build-ids listed in BUILD_IDS_FILE\n"
             "to CACHEDIR, using TMPDIR as temporary staging area.\n"
@@ -94,6 +94,7 @@ if __name__ == "__main__":
             "\n"
             "    -v          Be verbose\n"
             "    -y          Noninteractive, assume 'Yes' to all questions\n"
+            "    --keeprpms  Keep downloaded rpms in TMPDIR\n"
             "    --ids       Default: build_ids\n"
             "    --tmpdir    Default: @LARGE_DATA_TMP_DIR@/abrt-tmp-debuginfo-RANDOM_SUFFIX\n"
             "    --cache     Default: /var/cache/abrt-di\n"
@@ -101,7 +102,6 @@ if __name__ == "__main__":
             "    -e,--exact  Download only specified files\n"
             "    --repo      Pattern to use when searching for repos.\n"
             "                Default: *debug*\n"
-            # --keeprpms is not documented yet because it's a NOP so far
     ) % PROGNAME
 
     try:
@@ -211,10 +211,10 @@ if __name__ == "__main__":
         log2("%s", missing)
         print _("Coredump references {0} debuginfo files, {1} of them are not installed").format(len(b_ids), len(missing))
 
-        # TODO: should we pass keep_rpms=keeprpms to DebugInfoDownload here??
         downloader = DebugInfoDownload(cache=cachedirs[0], tmp=tmpdir,
                                        noninteractive=noninteractive,
-                                       repo_pattern=repo_pattern)
+                                       repo_pattern=repo_pattern,
+                                       keep_rpms=keeprpms)
         try:
             result = downloader.download(missing, download_exact_files=exact_fls)
         except Exception, ex:
-- 
1.8.3.1



More information about the Crash-catcher mailing list