[LIBREPORT PATCH] bugzilla_formatdup*.conf: clearly flag comment as a dup. rhbz#875312, 875233, 864891

Jiri Moskovcak jmoskovc at redhat.com
Tue Sep 10 13:33:47 UTC 2013


This patch doesn't fix the 864891, the request clearly says:

1) tell user that it will append to existing bug,
2) give him url so he can read existing comments,
3) probably use appropriate wording at beginning of the comment, so the 
comment looks eg. like:

and this patch fixes only the 3rd part.

--Jirka

On 09/02/2013 12:12 PM, Denys Vlasenko wrote:
> Signed-off-by: Denys Vlasenko <dvlasenk at redhat.com>
> ---
>   src/plugins/bugzilla_format.conf             |  2 ++
>   src/plugins/bugzilla_format_anaconda.conf    |  2 ++
>   src/plugins/bugzilla_formatdup.conf          | 10 +++++++++-
>   src/plugins/bugzilla_formatdup_anaconda.conf | 10 +++++++++-
>   4 files changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/src/plugins/bugzilla_format.conf b/src/plugins/bugzilla_format.conf
> index cad5876..4f321d9 100644
> --- a/src/plugins/bugzilla_format.conf
> +++ b/src/plugins/bugzilla_format.conf
> @@ -15,6 +15,8 @@
>   # - %summary: bug summary format string.
>   # - %attach: a list of elements to attach.
>   # - text, double colon (::) and the list of comma-separated elements.
> +#   Text can be empty (":: elem1, elem2. elem3" works),
> +#   in this case "Text:" header line will be omitted.
>   #
>   # Elements can be:
>   # - problem directory element names, which get formatted as
> diff --git a/src/plugins/bugzilla_format_anaconda.conf b/src/plugins/bugzilla_format_anaconda.conf
> index 8ac8b5c..4af7092 100644
> --- a/src/plugins/bugzilla_format_anaconda.conf
> +++ b/src/plugins/bugzilla_format_anaconda.conf
> @@ -15,6 +15,8 @@
>   # - %summary: bug summary format string.
>   # - %attach: a list of elements to attach.
>   # - text, double colon (::) and the list of comma-separated elements.
> +#   Text can be empty (":: elem1, elem2. elem3" works),
> +#   in this case "Text:" header line will be omitted.
>   #
>   # Elements can be:
>   # - problem directory element names, which get formatted as
> diff --git a/src/plugins/bugzilla_formatdup.conf b/src/plugins/bugzilla_formatdup.conf
> index f5e89f7..6eb1230 100644
> --- a/src/plugins/bugzilla_formatdup.conf
> +++ b/src/plugins/bugzilla_formatdup.conf
> @@ -15,6 +15,8 @@
>   # - %summary: bug summary format string.
>   # - %attach: a list of elements to attach.
>   # - text, double colon (::) and the list of comma-separated elements.
> +#   Text can be empty (":: elem1, elem2. elem3" works),
> +#   in this case "Text:" header line will be omitted.
>   #
>   # Elements can be:
>   # - problem directory element names, which get formatted as
> @@ -36,8 +38,14 @@
>   #   Nonexistent elements are silently ignored.
>   #   If none of elements exists, the section will not be created.
>
> -%summary:: [abrt] %package%[[: %crash_function%]][[: %reason%]][[: TAINTED %tainted_short%]]
> +# When dup is detected, BZ reported adds a comment to it.
> +# This comment may interrupt an ongoing conversation in the BZ.
> +# (Three people independently filed a bug against abrt about this).
> +# Need to clearly explain what this comment is, to prevent confusion.
> +# Hopefully, this line would suffice:
> +Another user experienced a similar problem:
>
> +# If user filled out comment field, show it:
>   :: %bare_comment
>
>   # var_log_messages has too much variance (time/date),
> diff --git a/src/plugins/bugzilla_formatdup_anaconda.conf b/src/plugins/bugzilla_formatdup_anaconda.conf
> index efe8fa1..03c7f87 100644
> --- a/src/plugins/bugzilla_formatdup_anaconda.conf
> +++ b/src/plugins/bugzilla_formatdup_anaconda.conf
> @@ -15,6 +15,8 @@
>   # - %summary: bug summary format string.
>   # - %attach: a list of elements to attach.
>   # - text, double colon (::) and the list of comma-separated elements.
> +#   Text can be empty (":: elem1, elem2. elem3" works),
> +#   in this case "Text:" header line will be omitted.
>   #
>   # Elements can be:
>   # - problem directory element names, which get formatted as
> @@ -36,8 +38,14 @@
>   #   Nonexistent elements are silently ignored.
>   #   If none of elements exists, the section will not be created.
>
> -%summary:: [abrt] %package%[[: %crash_function%]][[: %reason%]][[: TAINTED %tainted_short%]]
> +# When dup is detected, BZ reported adds a comment to it.
> +# This comment may interrupt an ongoing conversation in the BZ.
> +# (Three people independently filed a bug against abrt about this).
> +# Need to clearly explain what this comment is, to prevent confusion.
> +# Hopefully, this line would suffice:
> +Another user experienced a similar problem:
>
> +# If user filled out comment field, show it:
>   :: %bare_comment
>
>   # var_log_messages has too much variance (time/date),
>



More information about the Crash-catcher mailing list