[LIBREPORT PATCH] Replace %reporter thing in BZ reporter with "libreport_version" element

Jakub Filak jfilak at redhat.com
Mon Sep 9 13:36:31 UTC 2013


CLARIFICATION:

I don't insist on usage of %reporter keyword but I want to see the
reporter version.


On Mon, 2013-09-09 at 12:52 +0200, Denys Vlasenko wrote:
> On 09/09/2013 10:12 AM, Jakub Filak wrote:
> > If you add a new element like this one (libreport_version) and remove
> > %reporter keyword, you will see version of libreport used to create the
> > dump directory but you won't see the version of libreport used to file
> > the bug tracking ticket. But we need to know even the later mentioned
> > version because of bugs in formatting and so on.
> 
> There are more steps in problem processing,
> by this logic we need to know libreport version of every step
> separately, since they can be different too.

But there are only two interesting steps -> create and report.
The version from create step is covered by abrt_version.
The version from report step is covered by %reporter keyword.

> 
> I think that since the version is usually the same on every step,
> it is enough to record it once.

>From the emergency dump directory analysis, I know that users often
reports old dump directories with a newer version of libreport (I'm
sorry, but cannot give you any numbers), therefore I'd say that your
assumption that the version is usually the same on every step is not
valid.

When a user reports a problem, libreport runs all necessary events
(analyze, collect, report) and the events uses the currently installed
libreport tools and not those which created the dump directory.

When I triage ABRT bugs, I can usually deduce the creator version from
abrt_version element but I cannot deduce the reporter version from any
information.

> 
> > I've added the
> > %reporter keyword because the previous formatting algorithm provided this
> > information and I find it really useful.
> 
> I agree that it's useful.
> 
> However, why adding a special case for it when we already have a standard
> mechanism for adding information to problems (i.e. we add new elements
> to problem directories)?
> 

I don't find the creator version very useful. As I wrote above, I can
deduce the creator version from abrt_version element. The reporter
version is necessary for fixing bugs in the reporting process.



More information about the Crash-catcher mailing list