[PATCH 1/4] vmcore: don't fail if /etc/kdump.conf is not readable

Richard Marko rmarko at redhat.com
Mon Sep 2 11:21:08 UTC 2013


On 09/02/2013 01:01 PM, Jiri Moskovcak wrote:
> On 09/02/2013 11:26 AM, Richard Marko wrote:
>> +        sys.stderr.write("/etc/kdump.conf not readable, using "
>> +                         "default path '%s'\n" % dump_path)
>> +        return dump_path
>> +
>
> - please factor out the logging functions from
> abrt-action-analyze-core script and use it in both scripts
> - they also exists in the reportclient module in libreport, so maybe
> you can use them instead of creating just another abrt module

I've had a version which used syslog module instead of writing to stderr
but I've replaced it as the rest of the code uses stderr and I'll
be fixing this everywhere due to rhbz#1001139.

The question is where should these scripts log by default - to stderr or
to syslog?

I think using syslog is better than current situation.

-- 
Richard Marko



More information about the Crash-catcher mailing list