[SATYR PATCH] abrt: Don't fail if there's no dso_list

Nikola Pajkovsky npajkovs at redhat.com
Thu May 23 10:20:25 UTC 2013


Martin Milata <mmilata at redhat.com> writes:

> This behaviour prevented satyr from generating uReports for e.g. python
> crashes.
>
> Signed-off-by: Martin Milata <mmilata at redhat.com>
> ---
>  lib/abrt.c | 22 ++++++++++------------
>  1 file changed, 10 insertions(+), 12 deletions(-)

you know that, you've made it more complicated to read.

> diff --git a/lib/abrt.c b/lib/abrt.c
> index ae01ab9..682eed7 100644
> --- a/lib/abrt.c
> +++ b/lib/abrt.c
> @@ -221,23 +221,21 @@ sr_abrt_rpm_packages_from_dir(const char *directory,
>  
>      char *dso_list_contents = file_contents(directory, "dso_list",
>                                              error_message);

here you get one content of file. It's not plural. You don't get
multiple contents of one file. so file_contents() name doesn't make any
sense. 

-- 
Nikola


More information about the Crash-catcher mailing list