[SATYR PATCH 2/2] Disable fingerprinting on arches other than x86_64

Martin Milata mmilata at redhat.com
Tue May 21 13:02:23 UTC 2013


The code that does fingerprinting currently only supports x86_64 (and
though i386 support should not be difficult to add, it has low
priority). The architecture is detected at build time and fingerprinting
enabled only for x86_64.

Closes #81.

Signed-off-by: Martin Milata <mmilata at redhat.com>
---
 configure.ac | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index ea6716f..0429f14 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,4 +1,5 @@
 AC_INIT([satyr], [0.3], [crash-catcher at fedorahosted.org])
+AC_CANONICAL_TARGET
 AC_CONFIG_HEADERS([lib/config.h])
 AM_INIT_AUTOMAKE([-Wall -Werror foreign])
 AM_MAINTAINER_MODE
@@ -38,7 +39,7 @@ PKG_CHECK_MODULES([PYTHON], [python2],,[
 ])
 
 AC_CHECK_LIB([opcodes], [main], [have_libopcodes=yes], [have_libopcodes=no])
-[if test "$have_libopcodes" = "no"; then]
+[if test "$have_libopcodes" = "no" -a "$target_cpu" = "x86_64"; then]
     [echo "The libopcodes library was not found in the search path. The core stacktrace support "]
     [echo "will not be built.  If you want to build core fingerprinting support, please ensure"]
     [echo "that libopcodes is installed and its directory is included in the search path."]
@@ -65,14 +66,14 @@ for DIR in /lib /usr/lib /lib64 /usr/lib64; do
 done
 AC_MSG_RESULT([$opcodes_pic])
 
-[if test "$opcodes_pic" = "no"; then]
+[if test "$opcodes_pic" = "no" -a "$target_cpu" = "x86_64"; then]
     [echo "The libopcodes library on your system was not compiled with PIC. The core backtrace fingerprinting support "]
     [echo "will not be built.  If you want to build core backtrace support, please ensure"]
     [echo "that the provided libopcodes is build with -fPIC."]
     [echo "Then run configure again before attempting to build Satyr."]
 [fi]
 
-test ! \( "$opcodes_pic" = "yes" -a "$have_libopcodes" = "yes" \)
+test ! \( "$opcodes_pic" = "yes" -a "$have_libopcodes" = "yes" -a "$target_cpu" = "x86_64" \)
 have_good_libopcodes=$?
 AM_CONDITIONAL(HAVE_LIBOPCODES, test $have_good_libopcodes -eq 1)
 AC_DEFINE_UNQUOTED(HAVE_LIBOPCODES, $have_good_libopcodes, [Have libopcodes compiled with -fPIC])
-- 
1.7.11.7



More information about the Crash-catcher mailing list