[PATCH 1/2] abrt-gdb-exploitable: x86 factoring-out

Jakub Filak jfilak at redhat.com
Thu Jun 27 16:05:29 UTC 2013


On Thu, 2013-06-27 at 17:09 +0200, Denys Vlasenko wrote:

> +        self.instruction_is_pushing = (None != _fetch_insn_from_table(self.mnemonic, _x86_pushing_instr))
> +        self.instruction_is_division = (None != _fetch_insn_from_table(self.mnemonic, _x86_intdiv_instr))
> +        self.instruction_is_branch = (None != _fetch_insn_from_table(self.mnemonic, _x86_jumping_instr))
> +        self.instruction_is_return = (None != _fetch_insn_from_table(self.mnemonic, _x86_return_instr))


self.instruction_is_pushing = (_fetch_insn_from_table(self.mnemonic,
_x86_pushing_instr) is not None)
self.instruction_is_division = (_fetch_insn_from_table(self.mnemonic,
_x86_intdiv_instr) is not None)
self.instruction_is_branch = (_fetch_insn_from_table(self.mnemonic,
_x86_jumping_instr) is not None)
self.instruction_is_return = (_fetch_insn_from_table(self.mnemonic,
_x86_return_instr) is not None)



Please, try to follow PEP8 recommendations [1].

1: http://www.python.org/dev/peps/pep-0008/#introduction



More information about the Crash-catcher mailing list