[PATCH] abrt-cli status: fix the output

Jakub Filak jfilak at redhat.com
Wed Jun 26 07:07:54 UTC 2013


On Mon, 2013-06-24 at 17:24 +0200, Richard Marko wrote:
> On 06/24/2013 04:56 PM, Denys Vlasenko wrote:
> > On 06/24/2013 04:50 PM, Jakub Filak wrote:
> >> Is this patch related to some ticket?
> > No, it's a result of me looking at the output and thinking
> > "for me as a user, this message looks wrong".
> >
> >> Or why do you think that the patch
> >> fixes the output?
> > Because:
> > - numbers are not enclosed in quotes in English language
> > - assuming that user has '$' as shell prompt is unwarranted
> >
> 
> 
> +1
> 
> This patch makes it better.
> 

Sure, it looks much better.

I was just unhappy with the commit message because I don't know when we
have to reference a ticket in the commit message. I would say that if a
patch needs review then the patch also needs an reference to some
ticket. We should update the developer guide. Or am I completely wrong?



More information about the Crash-catcher mailing list