[ABRT PATCH v2 4/4] applet: stop saving configuration at exit

Jakub Filak jfilak at redhat.com
Fri Jun 21 14:06:54 UTC 2013


And overriding changes made by user in desktop session.

Related to #594

Signed-off-by: Jakub Filak <jfilak at redhat.com>
---
 src/applet/applet.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/src/applet/applet.c b/src/applet/applet.c
index f851c8d..c7232bd 100644
--- a/src/applet/applet.c
+++ b/src/applet/applet.c
@@ -1524,7 +1524,16 @@ next:
     if (notify_is_initted())
         notify_uninit();
 
-    save_user_settings();
+    /* It does not make much sense to save settings at exit and after
+     * introduction of system-config-abrt it is wrong to do that. abrt-applet
+     * is long-running application and user can modify the configuration files
+     * while abrt-applet run. Thus, saving configuration at desktop session
+     * exit would make someone's life really hard.
+     *
+     * abrt-applet saves configuration immediately after user input.
+     *
+     * save_user_settings();
+     */
 
     g_dbus_connection_signal_unsubscribe(g_system_bus, signal_ret);
     g_object_unref(g_system_bus);
-- 
1.8.2.1



More information about the Crash-catcher mailing list