[SATYR PATCH 0/2] Source code reorganization

Martin Milata mmilata at redhat.com
Thu Jun 13 09:51:11 UTC 2013


Following two patches are fairly large due to the code being moved around. It
has been also pushed to github branch 'source-reorganization' [1] for easier
review (e.g. github can show file renames in the first patch).

[1] https://github.com/abrt/satyr/commits/source-reorganization

Martin Milata (2):
  Move public headers into separate directory
  Move "method tables" to files where the methods are defined

 Makefile.am                   |   4 +-
 configure.ac                  |   1 +
 include/Makefile.am           |  52 +++++
 include/abrt.h                |  61 ++++++
 include/core/fingerprint.h    |  53 +++++
 include/core/frame.h          | 213 +++++++++++++++++++
 include/core/stacktrace.h     | 147 +++++++++++++
 include/core/thread.h         | 141 +++++++++++++
 include/core/unwind.h         |  38 ++++
 include/deb.h                 |  46 +++++
 include/distance.h            | 122 +++++++++++
 include/frame.h               |  64 ++++++
 include/gdb/frame.h           | 468 ++++++++++++++++++++++++++++++++++++++++++
 include/gdb/sharedlib.h       | 134 ++++++++++++
 include/gdb/stacktrace.h      | 318 ++++++++++++++++++++++++++++
 include/gdb/thread.h          | 263 ++++++++++++++++++++++++
 include/java/frame.h          | 263 ++++++++++++++++++++++++
 include/java/stacktrace.h     | 146 +++++++++++++
 include/java/thread.h         | 231 +++++++++++++++++++++
 include/json.h                | 131 ++++++++++++
 include/koops/frame.h         | 233 +++++++++++++++++++++
 include/koops/stacktrace.h    | 176 ++++++++++++++++
 include/location.h            | 161 +++++++++++++++
 include/metrics.h             | 219 ++++++++++++++++++++
 include/normalize.h           |  86 ++++++++
 include/operating_system.h    |  60 ++++++
 include/python/frame.h        | 188 +++++++++++++++++
 include/python/stacktrace.h   | 119 +++++++++++
 include/report.h              |  70 +++++++
 include/report_type.h         |  44 ++++
 include/rpm.h                 | 220 ++++++++++++++++++++
 include/stacktrace.h          |  87 ++++++++
 include/strbuf.h              | 159 ++++++++++++++
 include/thread.h              |  73 +++++++
 include/utils.h               | 381 ++++++++++++++++++++++++++++++++++
 lib/Makefile.am               |  53 +----
 lib/abrt.c                    |  12 +-
 lib/abrt.h                    |  61 ------
 lib/core_fingerprint.c        |   8 +-
 lib/core_fingerprint.h        |  53 -----
 lib/core_frame.c              |  16 +-
 lib/core_frame.h              | 213 -------------------
 lib/core_stacktrace.c         |  31 ++-
 lib/core_stacktrace.h         | 147 -------------
 lib/core_thread.c             |  21 +-
 lib/core_thread.h             | 141 -------------
 lib/core_unwind.c             |   2 +-
 lib/core_unwind.h             |  38 ----
 lib/core_unwind_elfutils.c    |   6 +-
 lib/core_unwind_libunwind.c   |   6 +-
 lib/deb.h                     |  46 -----
 lib/distance.c                |  20 +-
 lib/distance.h                | 122 -----------
 lib/frame.c                   |  90 --------
 lib/frame.h                   |  64 ------
 lib/gdb_frame.c               |  16 +-
 lib/gdb_frame.h               | 468 ------------------------------------------
 lib/gdb_sharedlib.c           |   2 +-
 lib/gdb_sharedlib.h           | 134 ------------
 lib/gdb_stacktrace.c          |  33 ++-
 lib/gdb_stacktrace.h          | 318 ----------------------------
 lib/gdb_thread.c              |  24 ++-
 lib/gdb_thread.h              | 263 ------------------------
 lib/generic_frame.c           |  45 ++++
 lib/generic_frame.h           |  33 +++
 lib/generic_stacktrace.c      | 124 +++++++++++
 lib/generic_stacktrace.h      |  57 +++++
 lib/generic_thread.c          |  90 ++++++++
 lib/generic_thread.h          |  51 +++++
 lib/internal_utils.h          |  33 +++
 lib/java_frame.c              |  16 +-
 lib/java_frame.h              | 263 ------------------------
 lib/java_stacktrace.c         |  24 ++-
 lib/java_stacktrace.h         | 146 -------------
 lib/java_thread.c             |  21 +-
 lib/java_thread.h             | 231 ---------------------
 lib/json.h                    | 131 ------------
 lib/koops_frame.c             |  16 +-
 lib/koops_frame.h             | 233 ---------------------
 lib/koops_stacktrace.c        |  32 ++-
 lib/koops_stacktrace.h        | 176 ----------------
 lib/location.h                | 161 ---------------
 lib/metrics.c                 |   4 +-
 lib/metrics.h                 | 219 --------------------
 lib/normalize.c               |  10 +-
 lib/normalize.h               |  86 --------
 lib/operating_system.h        |  60 ------
 lib/python_frame.c            |  16 +-
 lib/python_frame.h            | 188 -----------------
 lib/python_stacktrace.c       |  32 ++-
 lib/python_stacktrace.h       | 119 -----------
 lib/report.c                  |   8 +-
 lib/report.h                  |  70 -------
 lib/report_type.h             |  44 ----
 lib/rpm.h                     | 220 --------------------
 lib/stacktrace.c              | 210 -------------------
 lib/stacktrace.h              |  87 --------
 lib/strbuf.h                  | 159 --------------
 lib/thread.c                  | 155 --------------
 lib/thread.h                  |  73 -------
 lib/utils.h                   | 392 -----------------------------------
 python/Makefile.am            |   3 +-
 python/py_cluster.c           |   4 +-
 python/py_common.c            |   2 +-
 python/py_gdb_frame.c         |   8 +-
 python/py_gdb_sharedlib.c     |   4 +-
 python/py_gdb_stacktrace.c    |  12 +-
 python/py_gdb_thread.c        |   8 +-
 python/py_java_frame.c        |   8 +-
 python/py_java_stacktrace.c   |  12 +-
 python/py_java_thread.c       |  10 +-
 python/py_koops_frame.c       |   8 +-
 python/py_koops_stacktrace.c  |  12 +-
 python/py_metrics.c           |   4 +-
 python/py_module.c            |   2 +-
 python/py_python_frame.c      |   8 +-
 python/py_python_stacktrace.c |  14 +-
 satyr.c                       |  24 +--
 tests/abrt.at                 |   4 +-
 tests/atlocal.in              |   2 +-
 tests/cluster.at              |   8 +-
 tests/core_frame.at           |  14 +-
 tests/core_stacktrace.at      |  18 +-
 tests/core_thread.at          |  14 +-
 tests/gdb_frame.at            |  40 ++--
 tests/gdb_sharedlib.at        |  14 +-
 tests/gdb_stacktrace.at       |  42 ++--
 tests/gdb_thread.at           |  38 ++--
 tests/java_frame.at           |  34 +--
 tests/java_stacktrace.at      |  34 +--
 tests/java_testcases.c        |   8 +-
 tests/java_thread.at          |  50 ++---
 tests/koops_frame.at          |  12 +-
 tests/koops_stacktrace.at     |  18 +-
 tests/metrics.at              |  10 +-
 tests/normalize.at            |  18 +-
 tests/operating_system.at     |   4 +-
 tests/rpm.at                  |  12 +-
 tests/strbuf.at               |   4 +-
 tests/utils.at                |  44 ++--
 140 files changed, 6214 insertions(+), 5986 deletions(-)
 create mode 100644 include/Makefile.am
 create mode 100644 include/abrt.h
 create mode 100644 include/core/fingerprint.h
 create mode 100644 include/core/frame.h
 create mode 100644 include/core/stacktrace.h
 create mode 100644 include/core/thread.h
 create mode 100644 include/core/unwind.h
 create mode 100644 include/deb.h
 create mode 100644 include/distance.h
 create mode 100644 include/frame.h
 create mode 100644 include/gdb/frame.h
 create mode 100644 include/gdb/sharedlib.h
 create mode 100644 include/gdb/stacktrace.h
 create mode 100644 include/gdb/thread.h
 create mode 100644 include/java/frame.h
 create mode 100644 include/java/stacktrace.h
 create mode 100644 include/java/thread.h
 create mode 100644 include/json.h
 create mode 100644 include/koops/frame.h
 create mode 100644 include/koops/stacktrace.h
 create mode 100644 include/location.h
 create mode 100644 include/metrics.h
 create mode 100644 include/normalize.h
 create mode 100644 include/operating_system.h
 create mode 100644 include/python/frame.h
 create mode 100644 include/python/stacktrace.h
 create mode 100644 include/report.h
 create mode 100644 include/report_type.h
 create mode 100644 include/rpm.h
 create mode 100644 include/stacktrace.h
 create mode 100644 include/strbuf.h
 create mode 100644 include/thread.h
 create mode 100644 include/utils.h
 delete mode 100644 lib/abrt.h
 delete mode 100644 lib/core_fingerprint.h
 delete mode 100644 lib/core_frame.h
 delete mode 100644 lib/core_stacktrace.h
 delete mode 100644 lib/core_thread.h
 delete mode 100644 lib/core_unwind.h
 delete mode 100644 lib/deb.h
 delete mode 100644 lib/distance.h
 delete mode 100644 lib/frame.c
 delete mode 100644 lib/frame.h
 delete mode 100644 lib/gdb_frame.h
 delete mode 100644 lib/gdb_sharedlib.h
 delete mode 100644 lib/gdb_stacktrace.h
 delete mode 100644 lib/gdb_thread.h
 create mode 100644 lib/generic_frame.c
 create mode 100644 lib/generic_frame.h
 create mode 100644 lib/generic_stacktrace.c
 create mode 100644 lib/generic_stacktrace.h
 create mode 100644 lib/generic_thread.c
 create mode 100644 lib/generic_thread.h
 create mode 100644 lib/internal_utils.h
 delete mode 100644 lib/java_frame.h
 delete mode 100644 lib/java_stacktrace.h
 delete mode 100644 lib/java_thread.h
 delete mode 100644 lib/json.h
 delete mode 100644 lib/koops_frame.h
 delete mode 100644 lib/koops_stacktrace.h
 delete mode 100644 lib/location.h
 delete mode 100644 lib/metrics.h
 delete mode 100644 lib/normalize.h
 delete mode 100644 lib/operating_system.h
 delete mode 100644 lib/python_frame.h
 delete mode 100644 lib/python_stacktrace.h
 delete mode 100644 lib/report.h
 delete mode 100644 lib/report_type.h
 delete mode 100644 lib/rpm.h
 delete mode 100644 lib/stacktrace.c
 delete mode 100644 lib/stacktrace.h
 delete mode 100644 lib/strbuf.h
 delete mode 100644 lib/thread.c
 delete mode 100644 lib/thread.h
 delete mode 100644 lib/utils.h

-- 
1.7.11.7



More information about the Crash-catcher mailing list