[PATCH 1/8] abrt-handle-event: free more of allocated data

Denys Vlasenko dvlasenk at redhat.com
Wed Jul 31 10:21:08 UTC 2013


On 07/29/2013 04:23 PM, Jiri Moskovcak wrote:
> On 07/29/2013 03:49 PM, Martin Milata wrote:
>> Pushed, including the libreport patch.
>>
>> I noticed that when processing a crash, following line appers in the
>> syslog (possibly several times):
>>
>> abrt-server[10123]: Can't access '/var/tmp/abrt/post-create.lock': No such file or directory
>>
>> This is due to duplicate detection in abrt-handle-event which iterates
>> over all items in /var/tmp/abrt and fails to open the lock because it is
>> a broken symlink. While the log message could be avoided by adding
>> DD_FAIL_QUIETLY_EACCESS to the dd_opendir (or explicitly skipping the
>> lock), I was wondering why we don't store /proc/PID in the symlink
>> instead of just PID? This would make the symlink non-broken when the
>> locking process is still running.
>>
>> Martin
>>
> 
> Guys,
> neither of those patches references any ticket which lead
> to those changes which breaks the commit rules! Don't push such patches!

Sorry.

Thiese patches were for the issue #657 "divide abrtd into two parts"




More information about the Crash-catcher mailing list