[SATYR PATCH] Add source line to gdb frame text output

Jakub Filak jfilak at redhat.com
Mon Jul 22 13:04:04 UTC 2013


Closes #95

Signed-off-by: Jakub Filak <jfilak at redhat.com>
---
 lib/gdb_frame.c     |  2 ++
 tests/python/gdb.py | 10 +++++-----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/lib/gdb_frame.c b/lib/gdb_frame.c
index e3985c4..7cf0287 100644
--- a/lib/gdb_frame.c
+++ b/lib/gdb_frame.c
@@ -282,6 +282,8 @@ sr_gdb_frame_append_to_str(struct sr_gdb_frame *frame,
         if (frame->function_name)
             sr_strbuf_append_str(str, " at");
         sr_strbuf_append_strf(str, " %s", frame->source_file);
+        if (frame->source_line != -1)
+            sr_strbuf_append_strf(str, ":%d", frame->source_line);
     }
 
     if (frame->signal_handler_called)
diff --git a/tests/python/gdb.py b/tests/python/gdb.py
index 2752771..fdc61a6 100755
--- a/tests/python/gdb.py
+++ b/tests/python/gdb.py
@@ -13,11 +13,11 @@ contents = load_input_contents('../gdb_stacktraces/rhbz-803600')
 threads_expected = 2
 frames_expected = 227
 expected_short_text = '''Thread no. 1 (5 frames)
- #0 validate_row at gtktreeview.c
- #1 validate_visible_area at gtktreeview.c
- #2 gtk_tree_view_bin_expose at gtktreeview.c
- #3 gtk_tree_view_expose at gtktreeview.c
- #4 _gtk_marshal_BOOLEAN__BOXED at gtkmarshalers.c
+ #0 validate_row at gtktreeview.c:5699
+ #1 validate_visible_area at gtktreeview.c:5898
+ #2 gtk_tree_view_bin_expose at gtktreeview.c:4253
+ #3 gtk_tree_view_expose at gtktreeview.c:4955
+ #4 _gtk_marshal_BOOLEAN__BOXED at gtkmarshalers.c:84
 '''
 
 class TestGdbStacktrace(BindingsTestCase):
-- 
1.8.3.1



More information about the Crash-catcher mailing list