Handle BlackListedPaths in abrt coredump hook too?

Denys Vlasenko dvlasenk at redhat.com
Thu Jul 18 12:02:07 UTC 2013


On 07/18/2013 01:47 PM, Jiri Moskovcak wrote:
> On 07/18/2013 01:37 PM, Denys Vlasenko wrote:
>> Currently we have
>>
>>     BlackListedPaths = /usr/share/doc/*, */example*, /usr/bin/nspluginviewer, /usr/lib/xulrunner-*/plugin-container
>>
>> in abrt-action-save-package-data.conf, and
>> abrt-action-save-package-data will fail (exit with 1)
>> if it sees one of these executables.
>> (Sans a bug which I just noticed there. Sigh...).


...and patch is sent :)
Can you take a look?


>> """
>> When an application is coring, the network connections are not
>> torn down till the application is done coring.
>> This is unfortunate as it means connectivity
>> isn’t severed and we don’t get cancel on disconnect
>> till the core is done.
>> """
>> This looks like a genuine situation to me.
>>
>>
>> I suggested this, among other possible solutions:
>> """
>> If they don't absolutely need to have coredumps,
>> they can disable coredumping for the programs they
>> want to terminate fast(er). Either via shell ("ulimit -c 0") or in C:
>>                 struct_rlimit rlim = {0, 0};
>>                  set_rlimit(RLIMIT_CORE, &rlim);
>> """
>>
>> but it's won't _really_ help if abrt hook is installed:
>> it still will be called, and still will read and save
>> entire coredump.
>>
>> If we can teach coredump helper to check BlackListedPaths
>> and abort coredump at once, it will help them:
>> they can simply add their app to BlackListedPaths.
>>
>> Question #1: do we want to implement this?
>>
>> Question #2: isn't abrt-action-save-package-data.conf
>> a wrong file for this conf item, then?
>> Where should it be moved? /etc/abrt/blacklist.conf?
>>
> 
> - as we discussed yesterday:
>  - create file /etc/abrt/blacklist.conf and move the blacklist to it (all?, just executables??)
>  - teach ccpp-hook to use it (but it should ignore the blacklist if ulimit != 0 and create compat core)

Ok, I'm doing it.


More information about the Crash-catcher mailing list