<div dir="ltr"><div><div><div>This last patch changes that. <br><br></div>If we are going to read versions from spec I would advise to remove the __version__ from the code python files since it won't reflect any real version or useful information.<br><br></div>Cheers,<br><br></div>Sergio Oliveira<br><div><div><div><div><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 20, 2015 at 3:43 AM Miroslav Suchy <<a href="mailto:msuchy@redhat.com">msuchy@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 10/19/2015 09:59 PM, Sergio Oliveira wrote:<br>
> Hello,<br>
><br>
> I've the need of using copr-cli in other distros so I've decided to<br>
> upload it to PyPI. In order to do that I had to change the setup.py file<br>
> in both copr-cli and copr-python projects.<br>
><br>
> The problem is that the setup.py was importing the code it was supposed<br>
> to install and breaking because the dependencies weren't installed yet.<br>
> To fix that I've added a function that parses the content of the file<br>
> looking for it's version instead of importing it.<br>
><br>
> Doing that the installer is able to build the dependencies tree and look<br>
> for each dependency on the package index.<br>
><br>
> Also the Alpha classifier used was wrong so I've changed it from:<br>
><br>
> "Development Status :: 1 - Alpha"<br>
><br>
> to<br>
><br>
> "Development Status :: 3 - Alpha"<br>
><br>
> Last, I've updated the versions to use the tagged versions. You will<br>
> find my commits attached.<br>
<br>
Thank you for doing that.<br>
However for us the relevant version is in the spec file. Is it possible<br>
to alter the patch so it reads and parse the version from the spec file?<br>
<br>
Mirek<br>
<br>
<br>
_______________________________________________<br>
copr-devel mailing list<br>
<a href="mailto:copr-devel@lists.fedorahosted.org" target="_blank">copr-devel@lists.fedorahosted.org</a><br>
<a href="https://lists.fedorahosted.org/mailman/listinfo/copr-devel" rel="noreferrer" target="_blank">https://lists.fedorahosted.org/mailman/listinfo/copr-devel</a><br>
</blockquote></div></div></div></div></div></div>