footer and stylesheet

Frankie Onuonga frankie.onuonga at gmail.com
Mon Sep 23 11:08:30 UTC 2013


On Mon, 2013-09-23 at 10:44 +0200, Pierre-Yves Chibon wrote:
> On Mon, Sep 23, 2013 at 10:33:35AM +0200, Miroslav Suchy wrote:
> > On 09/23/2013 09:59 AM, Frankie Onuonga wrote:
> > >Hi,
> > >Attached is a patch for the footer and its style sheet.
put the footer css style on the main css file for copr under static.
> > >because I am still working on understanding on how to send patches here
> > >that don't do direct sync i decided to put the files in separate
> > >directories.
> > >This will ensure if it does not work it will not break anything else.
> > >Sorry I took so long for this.
> > >Been a hectic week at work.
> > >
> > 
> > You patch apply cleanly. But I see several other problems:
> > 
> > * It is Patch 2/2. It means that you probably wanted to send us
> > Patch 1/2 as well?
> > 
> > * you have:
> >   href="{{ url_for('static', filename='footer.css')
> > but footer.css is in templates and not static, therefore this url
> > could not resolve.
> > Please either put it into static directory. Or even better put that
> > style directly into copr.css
> > 
> > * who refer to footer.html? It seems to me, that it will not be used.
> 
> * The urls in footer.html do not point to anything at the moment, but I guess
> this is still work in progress :)
> 
> Pierre
> _______________________________________________
> copr-devel mailing list
> copr-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/copr-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-combined-the-footer-and-main-copr-css.patch
Type: text/x-patch
Size: 1595 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/copr-devel/attachments/20130923/4f265ed1/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 572 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/copr-devel/attachments/20130923/4f265ed1/attachment.sig>


More information about the copr-devel mailing list