[copr] master: Only create build with those mock chroots that are active (4fe9501)

bkabrda at fedoraproject.org bkabrda at fedoraproject.org
Wed Mar 20 15:27:20 UTC 2013


Repository : http://git.fedorahosted.org/cgit/copr.git

On branch  : master

>---------------------------------------------------------------

commit 4fe9501fe2e52b8e2eeb9f0933edc0ea3dc60e6c
Author: Bohuslav Kabrda <bkabrda at redhat.com>
Date:   Wed Mar 20 16:18:27 2013 +0100

    Only create build with those mock chroots that are active


>---------------------------------------------------------------

 coprs_frontend/coprs/logic/builds_logic.py         |    6 +++---
 .../tests/test_logic/test_builds_logic.py          |   10 ++++++++++
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/coprs_frontend/coprs/logic/builds_logic.py b/coprs_frontend/coprs/logic/builds_logic.py
index 2ee9a07..1ef7252 100644
--- a/coprs_frontend/coprs/logic/builds_logic.py
+++ b/coprs_frontend/coprs/logic/builds_logic.py
@@ -61,9 +61,9 @@ class BuildsLogic(object):
             pkgs=pkgs,
             copr=copr,
             repos=copr.repos,
-            chroots=' '.join(map(
-                lambda x: x.chroot_name, copr.mock_chroots)
-                ),
+            chroots=' '.join(map(lambda x: x.chroot_name,
+                             filter(lambda b: b.is_active, #only add active chroots
+                                    copr.mock_chroots))),
             user=user,
             submitted_on=int(time.time()))
         # no need to check for authorization here
diff --git a/coprs_frontend/tests/test_logic/test_builds_logic.py b/coprs_frontend/tests/test_logic/test_builds_logic.py
new file mode 100644
index 0000000..007f649
--- /dev/null
+++ b/coprs_frontend/tests/test_logic/test_builds_logic.py
@@ -0,0 +1,10 @@
+from coprs.logic.builds_logic import BuildsLogic
+from tests.coprs_test_case import CoprsTestCase
+
+class TestBuildsLogic(CoprsTestCase):
+    def test_add_only_adds_active_chroots(self, f_users, f_coprs, f_builds, f_mock_chroots, f_db):
+        self.mc2.is_active = False
+        self.db.session.commit()
+        b = BuildsLogic.add(self.u2, 'blah blah', self.c2)
+        self.db.session.commit()
+        assert b.chroots == self.mc3.chroot_name



More information about the copr-devel mailing list