[copr] master: Rename add_copr to add - move it to more logical place in source file just to keep it nice :) (4294989)

bkabrda at fedoraproject.org bkabrda at fedoraproject.org
Thu Jan 24 12:01:27 UTC 2013


Repository : http://git.fedorahosted.org/cgit/copr.git

On branch  : master

>---------------------------------------------------------------

commit 42949891dcf831cd79145cfd57596ce754fa8f5c
Author: Bohuslav Kabrda <bkabrda at redhat.com>
Date:   Thu Jan 24 12:47:11 2013 +0100

    Rename add_copr to add
    - move it to more logical place in source file just to keep it nice :)


>---------------------------------------------------------------

 coprs_frontend/coprs/logic/coprs_logic.py          |   28 ++++++++++----------
 .../coprs/views/coprs_ns/coprs_general.py          |   12 ++++----
 2 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/coprs_frontend/coprs/logic/coprs_logic.py b/coprs_frontend/coprs/logic/coprs_logic.py
index 615be26..1d44ea2 100644
--- a/coprs_frontend/coprs/logic/coprs_logic.py
+++ b/coprs_frontend/coprs/logic/coprs_logic.py
@@ -25,20 +25,6 @@ class CoprsLogic(object):
         return query
 
     @classmethod
-    def add_copr(cls, user, name, repos, selected_chroots, description, instructions):
-        copr = models.Copr(name=name,
-                           repos=repos,
-                           owner=user,
-                           description=description,
-                           instructions=instructions,
-                           created_on=int(time.time()))
-        CoprsLogic.new(user, copr,
-            check_for_duplicates=False) # form validation checks for duplicates
-        CoprsChrootLogic.new_from_names(user, copr,
-            selected_chroots)
-        return copr
-
-    @classmethod
     def get_multiple(cls, user, **kwargs):
         user_relation = kwargs.get('user_relation', None)
         username = kwargs.get('username', None)
@@ -61,6 +47,20 @@ class CoprsLogic(object):
         return query
 
     @classmethod
+    def add(cls, user, name, repos, selected_chroots, description, instructions):
+        copr = models.Copr(name=name,
+                           repos=repos,
+                           owner=user,
+                           description=description,
+                           instructions=instructions,
+                           created_on=int(time.time()))
+        CoprsLogic.new(user, copr,
+            check_for_duplicates=False) # form validation checks for duplicates
+        CoprsChrootLogic.new_from_names(user, copr,
+            selected_chroots)
+        return copr
+
+    @classmethod
     def new(cls, user, copr, check_for_duplicates = True):
         if check_for_duplicates and cls.exists_for_current_user(user, copr.name):
             raise exceptions.DuplicateCoprNameException
diff --git a/coprs_frontend/coprs/views/coprs_ns/coprs_general.py b/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
index 15ac156..de39536 100644
--- a/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
+++ b/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
@@ -64,12 +64,12 @@ def copr_new():
     """
     form = forms.CoprFormFactory.create_form_cls()()
     if form.validate_on_submit():
-        copr = coprs_logic.CoprsLogic.add_copr(flask.g.user,
-                                               name=form.name.data,
-                                               repos=form.repos.data.replace('\n', ' '),
-                                               selected_chroots=form.selected_chroots,
-                                               description=form.description.data,
-                                               instructions=form.instructions.data)
+        copr = coprs_logic.CoprsLogic.add(flask.g.user,
+                                          name=form.name.data,
+                                          repos=form.repos.data.replace('\n', ' '),
+                                          selected_chroots=form.selected_chroots,
+                                          description=form.description.data,
+                                          instructions=form.instructions.data)
         db.session.commit()
         flask.flash('New copr was successfully created.')
 



More information about the copr-devel mailing list