[copr] master: Fix objects not being deleted from collections of associated (0478e92)

bkabrda at fedoraproject.org bkabrda at fedoraproject.org
Wed Jan 23 15:16:55 UTC 2013


Repository : http://git.fedorahosted.org/cgit/copr.git

On branch  : master

>---------------------------------------------------------------

commit 0478e924d5184e8b97f2b634f5563163464a52ad
Author: Bohuslav Kabrda <bkabrda at redhat.com>
Date:   Wed Jan 23 16:15:46 2013 +0100

    Fix objects not being deleted from collections of associated


>---------------------------------------------------------------

 coprs_frontend/coprs/logic/coprs_logic.py |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/coprs_frontend/coprs/logic/coprs_logic.py b/coprs_frontend/coprs/logic/coprs_logic.py
index 0401a3b..c25bd72 100644
--- a/coprs_frontend/coprs/logic/coprs_logic.py
+++ b/coprs_frontend/coprs/logic/coprs_logic.py
@@ -159,3 +159,8 @@ class CoprsChrootLogic(object):
                 models.CoprChroot.query.filter(models.CoprChroot.copr_id==copr.id).\
                                         filter(models.CoprChroot.mock_chroot_id==mock_chroot.id).\
                                         delete()
+            # TODO: fails because of
+            # http://docs.sqlalchemy.org/en/rel_0_7/orm/session.html#deleting-from-collections
+            # figure out how to overcome it nicely without having to commit the session
+            # (deleting the copr_chroot object from copr.copr_chroots doesn't seem to help)
+            db.session.commit()



More information about the copr-devel mailing list