[copr] master: Some playing around with the builds table (918ed51)

bkabrda at fedoraproject.org bkabrda at fedoraproject.org
Tue Jan 22 07:02:10 UTC 2013


Repository : http://git.fedorahosted.org/cgit/copr.git

On branch  : master

>---------------------------------------------------------------

commit 918ed51bb89319538779ce2618d493f8cdbcfe54
Author: Bohuslav Kabrda <bkabrda at redhat.com>
Date:   Mon Jan 21 14:04:13 2013 +0100

    Some playing around with the builds table


>---------------------------------------------------------------

 coprs_frontend/coprs/static/style-new.css          |   12 ++++++++++++
 .../templates/coprs/detail/_builds_table.html      |   19 +++++++++++--------
 2 files changed, 23 insertions(+), 8 deletions(-)

diff --git a/coprs_frontend/coprs/static/style-new.css b/coprs_frontend/coprs/static/style-new.css
index 8265cff..6c36042 100644
--- a/coprs_frontend/coprs/static/style-new.css
+++ b/coprs_frontend/coprs/static/style-new.css
@@ -236,6 +236,18 @@ table.builds-table {
   width: 100%;
 }
 
+table.builds-table td.build-end {
+  border-bottom: 2px solid #4d4d4d;
+}
+
+table.builds-table form {
+  display: inline;
+}
+
+table.builds-table tr.build-details {
+  display: none;
+}
+
 tr.build-pending {
   color: #3B6EB4;
 }
diff --git a/coprs_frontend/coprs/templates/coprs/detail/_builds_table.html b/coprs_frontend/coprs/templates/coprs/detail/_builds_table.html
index dfaf9de..3b15490 100644
--- a/coprs_frontend/coprs/templates/coprs/detail/_builds_table.html
+++ b/coprs_frontend/coprs/templates/coprs/detail/_builds_table.html
@@ -10,8 +10,6 @@
         <th>Started on</th>
         <th>Ended on</th>
         <th>State</th>
-        <th>Results</th>
-        <th>Action</th>
       </tr>
     {% for build in builds %}
       <tr class="build-{{ build.state }}">
@@ -21,18 +19,23 @@
         <td>{{ build.started_on|date_from_secs or 'Not yet' }}</td>
         <td>{{ build.ended_on|date_from_secs or 'Not yet' }}</td>
         <td>{{ build.state }}</td>
-        <td>{% if build.results %}<a href="{{ build.results }}">{% endif %}{{ build.results }}{% if build.results %}</a>{% endif %}</td>
-        <td>
+      </tr>
+      <tr class="build-details">
+        <td colspan=6 class="build-end">
+          <div>
           {% if g.user and g.user == build.user %}
             {{ copr_build_cancel_form(build) }}
           {% endif %}
           {% if g.user and g.user.can_build_in(copr) %}
             {{ copr_build_repeat_form(build) }}
           {% endif %}
-        </td>
-      </tr>
-      <tr>
-        <td colspan=8>
+          <div>
+            {% if build.results %}
+              <h2>Results: </h2><a href="{{ build.results }}">{{ build.results }}</a>
+            {% else %}
+              <h2>No results yet.</h2>
+            {% endif %}
+          <div>
           <h2>Package URLs:</h2>
           <div class="pkg-url-list">{% if build.pkgs is not none %}{% for pkg in build.pkgs.split() %}<a href="{{ pkg }}">{{ pkg }}</a>
 {% endfor %}{% endif %}</div>



More information about the copr-devel mailing list